Repository navigation
Confine scheduled observation entries to their own animal - #759
Merged
labkey-martyp merged 1 commit intoSep 15, 2026
Merged
Conversation
An observation order's taskid identifies the ordering session, so orders for several animals share one; the scheduled-observation lookup filtered on taskid alone and spilled the entry onto every animal in that order.
labkey-bpatel
approved these changes
Sep 14, 2026
labkey-martyp
commented
Sep 15, 2026
labkey-martyp
left a comment
labkey-martyp
left a comment
Contributor
Author
There was a problem hiding this comment.
Unrelated test failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Fixes scheduled observation entries spilling onto unrelated animals: recording an observation from the schedule for one animal also created entries for every other animal whose observation order came from the same ordering session.
An observation order's taskid identifies that ordering session rather than the animal, so the schedule link carries a taskid that several animals' orders share. The form grid loads only the animal it was opened for, but the save path did not narrow to that animal, and could also file the entered row against another animal's case and order.
Related Pull Requests
None.
Changes