Repository navigation
Scope NIRC EHR report assertions to the animal under test - #766
Merged
labkey-martyp merged 2 commits intoSep 20, 2026
Merged
Conversation
The medication schedule and active case reports cover the whole folder, so orders and cases left open by other tests were counted against these two tests.
The Active Clinical Cases report is folder-wide, so row 0 could be a case another test left open.
labkey-bpatel
approved these changes
Sep 18, 2026
labkey-martyp
commented
Sep 20, 2026
labkey-martyp
left a comment
labkey-martyp
left a comment
Contributor
Author
There was a problem hiding this comment.
I see green tests!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Three NIRC_EHRTest tests assert against reports that cover the whole folder, so records other tests leave behind get counted as their own: stray active treatment orders inflate the medication schedule and behavior order counts, and clinical cases left open can sit at row 0 of the Active Clinical Cases report, sending a test into the wrong animal's case form.
Related Pull Requests
None.
Changes