Remove SQLServer support - #1892
Merged
Merged
Conversation
labkey-jeckels
requested review from
labkey-adam,
labkey-bpatel and
labkey-martyp
September 13, 2026 23:11
labkey-adam
previously approved these changes
Sep 14, 2026
| return; | ||
|
|
||
| SQLFragment latestHxSql = new SQLFragment("(SELECT " + prefix + " (" + "r.hx" + ") as _expr FROM " + realTable.getSelectName() + | ||
| SQLFragment latestHxSql = new SQLFragment("(SELECT (" + "r.hx" + ") as _expr FROM " + realTable.getSelectName() + |
Contributor
There was a problem hiding this comment.
Could inline these string literals instead of concatenating them, of course (here and below, four total)
Contributor
Author
There was a problem hiding this comment.
Removed all of the " + " in the file
labkey-martyp
previously approved these changes
Sep 14, 2026
labkey-jeckels
dismissed stale reviews from labkey-martyp and labkey-adam
via
September 14, 2026 16:04
4ec373f
Contributor
Author
|
@labkey-martyp @labkey-adam I think I accidentally dismissed previous approvals. Can you reapprove? |
labkey-martyp
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We no longer support SQLServer.
Changes