[bot] Fast-forward for 26.3.15#7802
Merged
Merged
Conversation
…7796) ## Rationale Newer browsers (Chrome, Firefox 140+) ship a native `RegExp.escape` that throws a `TypeError` on non-String input. `Ext.ux.form.LovCombo.setValue()` passed `JSON.stringify(value)` to `RegExp.escape` to avoid that crash, but `JSON.stringify()` quotes string values, so they no longer matched the raw, unquoted output of `getCheckedValue()` and every selection in a string-valued combo (e.g. the WNPRC EHR Time of Day multi-select) was silently dropped. Using `String()` yields a valid String for `RegExp.escape` without quoting string values, fixing both the numeric-`valueField` crash and the string-`valueField` regression. See LabKey/internal-issues#1266. ## Related Pull Requests - LabKey/wnprc-modules#982 - LabKey/premiumModules#638 ## Changes - `core/webapp/Ext.ux.form.LovCombo.js`: in `setValue()`, pass `String(...)` rather than `JSON.stringify(...)` to `RegExp.escape`.
labkey-tchad
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated automatically.
Approve all matching PRs simultaneously.
Approval will trigger automatic merge.
View all PRs: https://internal.labkey.com/Scrumtime/Backlog/harvest-gitOpenPullRequests.view?branch=26.3_ff_bot_26.3.15