GitHub Issue 1117: sample type and dataclass foreign keys#7804
Open
XingY wants to merge 8 commits into
Open
Conversation
This reverts commit 238671b.
labkey-adam
approved these changes
Jul 2, 2026
| try | ||
| { | ||
| DomainKind<?> kind = domain.getDomainKind(); | ||
| if (kind instanceof SampleTypeDomainKind || kind instanceof DataClassDomainKind) |
Contributor
There was a problem hiding this comment.
A comment about why only these domain kinds get FKs would be helpful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
DO NOT MERGE, TARGET 26.7
ForeignKeys defined on DomainKind are not enforced in
StorageProvisionerImpl._createand it's up to each caller to explicitly copy domainKind FK to domain, when creating the domain. Such change is risky as FK conditions are not always met, such as when importing assay xar. This PR instead scope the fix to just sample types and dataclasses, during domain creation and folder import actions.Related Pull Requests
Changes