GitHub Issue 1086: Add metrics for some problematic special characters in fields#7808
Open
XingY wants to merge 2 commits into
Open
GitHub Issue 1086: Add metrics for some problematic special characters in fields#7808XingY wants to merge 2 commits into
XingY wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
GitHub Issue 1086.
This PR adds a usage metric so we can understand how frequently some problematic special characters (semicolons, commas, newlines, and double-quotes) actually occur. broken down by special character and by field type.
Related Pull Requests
Changes
SpecialCharacterMetricsMaintenanceTasksystem maintenance task (due to performance concern, PostgreSQL only) that computes, per special character, the number of fields whose values (or defined choices) contain that character, grouped bycategory.
name, which is reported under dataName category.exp.objectpropertybacked domains (assay run, workflow custom fields, etc) don't distinguish between text/multiline, and are reported underobjectStringValue