Eliminate X-Frame-Options setting#7831
Merged
Merged
Conversation
…resent in the CSP
labkey-jeckels
approved these changes
Jul 9, 2026
labkey-adam
added a commit
to LabKey/testAutomation
that referenced
this pull request
Jul 9, 2026
#### Rationale This ` X-Frame-Options` setting has been removed. So has the `CSRF` setting (long ago). #### Related Pull Requests - LabKey/platform#7831
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The
frame-ancestorsdirective of our standard CSP is the modern way to control what other sites can "frame" a LabKey deployment (none, by default). TheX-Frame-Optionsheader is effectively obsolete, ignored by any browser that supportsframe-ancestors. All major browsers have supportedframe-ancestorsfor 10 years and hence ignoreX-Frame-Options.Related Pull Requests
User Education
X-Frame-Optionsheader setting in Site Settings in favor of theframe-ancestorsdirective in the standard CSP. If necessary, this (and all other CSP directives) can be customized on the "Allowed External Resource Hosts" administration page.Serverheader setting into the "Security settings" section. (Note that the Ext3 mentions should be removed from this page as well, https://github.com/LabKey/internal-issues/issues/1177)