PuppeteerHelper: use localhost#3073
Merged
Merged
Conversation
labkey-tchad
approved these changes
Jun 25, 2026
labkey-alan
force-pushed
the
fb_refuse_insecure_puppeteer
branch
from
ea65574 to
affbd92
Compare
labkey-alan
force-pushed
the
fb_refuse_insecure_puppeteer
branch
from
affbd92 to
19ab434
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
My changes in https://github.com/LabKey/limsModules/pull/2260 make it so insecure requests to non-loopback hosts are refused for by the puppeteer service. This PR updates the PuppeteerHelper to use localhost so the API requests don't get denied.
Related Pull Requests
Changes
Tasks 📍