Fix for notification menu 'View all activity'#3080
Merged
DariaBod merged 2 commits intoJul 2, 2026
Conversation
labkey-danield
left a comment
labkey-danield
left a comment
Contributor
There was a problem hiding this comment.
I'm ok with retrying but I wonder if the call to elementCache().viewAllLink() might be part of the problem. Specifically it's dependency on menuContent in the elementCache.
| } | ||
| catch (StaleElementReferenceException | NoSuchElementException retry) | ||
| { | ||
| return false; |
Contributor
There was a problem hiding this comment.
Should this do a collapse() before retrying?
I also wonder if part of the issue might be:
public final WebElement menuContent = Locator.byClass("navbar-menu__content").refindWhenNeeded(this);
in the element cache. Maybe this should be a locator, or put in a method so it is found everytime it is referenced.
Contributor
Author
There was a problem hiding this comment.
Switched toggle to refindWhenNeeded so it recovers on re-render, and kept the retry for the transient not-yet-rendered case.
DariaBod
force-pushed
the
26.3_fb_fixNotificationMenuViewAllTests
branch
from
f5e3ca0 to
8af4f95
Compare
labkey-danield
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Dropdown menu click isn't working sometimes because of re-rendering.
Related Pull Requests
Changes