DockerRStudioTest.testDataRegionExport failure - #3155
Merged
Conversation
cnathe
marked this pull request as ready for review
August 18, 2026 15:04
labkey-tchad
approved these changes
Aug 18, 2026
labkey-tchad
left a comment
labkey-tchad
left a comment
Member
There was a problem hiding this comment.
Is the two second sleep necessary, or just a belt and suspenders situation?
Contributor
Author
just belt and suspenders. I didn't want to go through too many iterations for this failure since it was clearly a timing issue and a race condition that was resulting in log errors but not functional issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Site logs are showing errors for deadlocks in this test when it it trying to index the samples in a sample type while the test is trying to delete the sample type. These errors are logged but the delete retries and eventually succeeds (and the search index handles already deleted samples) so the result here is as expected. This PR attempts to prevent the error logging by adding a wait for the search indexer to complete before deleting the sample type.
Related Pull Requests
Changes