Repository navigation
Remove Mascot test infrastructure - #3231
Merged
Merged
Conversation
4 tasks done
labkey-jeckels
marked this pull request as ready for review
October 6, 2026 04:21
labkey-jeckels
requested review from
a team and
DariaBod
and removed request for
a team
October 6, 2026 04:21
DariaBod
approved these changes
Oct 7, 2026
labkey-jeckels
added a commit
to LabKey/commonAssays
that referenced
this pull request
Oct 8, 2026
## Rationale Remove Mascot support from the MS2 module, which has gone unused for years. ## Related Pull Requests - LabKey/testAutomation#3231 ## Changes - Remove the Mascot search pipeline, the Mascot server configuration and connection test, and native `.dat` result import, viewing, and search indexing - Remove the Mascot run type, so Mascot-exported pepXML now imports as an unknown search engine - Upgrade script permanently drops the Mascot-only file columns from `ms2.Runs` and deletes the stored Mascot server settings - Existing Mascot runs stay in the database but display as an unknown run type, without their peptide grid, Mascot scores, MS2 search listing, experiment-run link for pipeline searches, or spectra for native `.dat` imports - Saved views, reports, and queries that reference the removed Mascot tables or columns will no longer resolve - Remove the Mascot test and sample data - Drop the unused opencsv and Lombok dependencies ## Tasks - [x] Claude Code Review - [x] Manual Testing - N/A - [x] Test Automation - N/A - [x] User Education @labkey-hannah @labkey-keith - not needed - I (Josh) don't think that anyone will care - But we can drop anything in the docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Remove test infrastructure for Mascot, whose support is being removed from the MS2 module.
Related Pull Requests
Changes