Skip to content

Retry notification menu waits across list refreshes - #3239

Open
labkey-jeckels wants to merge 2 commits into
developfrom
fb_notification_menu_refresh_wait
Open

labkey-jeckels wants to merge 2 commits into
developfrom
fb_notification_menu_refresh_wait

Conversation

@labkey-jeckels

Copy link
Copy Markdown
Contributor

Rationale

Fix intermittent Sample Manager test failures where the notifications dropdown re-renders while a test is reading it. Each notification refresh briefly replaces the listing with a loading spinner, so waits and clicks that hold an element reference fail with stale or missing elements. This hit 14 of 1,055 Sample Manager shard builds since 2026-09-01, across 10 branches including develop. Examples on develop: StaleElementReferenceException and NoSuchElementException.

Related Pull Requests

  • None

Changes

  • Waiting for the notification list now re-finds the list on every poll and treats a refresh in progress as "not yet", with a longer timeout.
  • Clicking a notification's view link retries if the list is refreshing.

@labkey-danield
labkey-danield self-requested a review October 9, 2026 17:22
@labkey-nicka labkey-nicka added this to the 26.11 milestone Oct 9, 2026
@labkey-danield

Copy link
Copy Markdown
Contributor

Changes to shared test components does not automatically kick off tests for the apps.
Those need to be kicked off manually and validated.

@labkey-jeckels

Copy link
Copy Markdown
Contributor Author

Verification runs on this branch for the two tests that failed on develop:

  • SMProAsyncImportAndNotificationTest (Sample Manager [D] postgres): passed, 1 run (build)
  • SMCrossTypeSampleFileImportTest (Sample Manager Starter postgres): passed, 5 runs across the parallel batches (build)

The failure rate was roughly 1 in 75 builds, so these runs show the fix doesn't break the tests but can't prove the race is gone.

@labkey-jeckels

Copy link
Copy Markdown
Contributor Author

Changes to shared test components does not automatically kick off tests for the apps. Those need to be kicked off manually and validated.

See separate followup comment - I just ran individual tests where I had seen failures instead of the full suite. I can run full suites if you think it's worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants