Repository navigation
Retry notification menu waits across list refreshes - #3239
Open
labkey-jeckels wants to merge 2 commits into
Open
labkey-jeckels wants to merge 2 commits into
labkey-jeckels wants to merge 2 commits into
Conversation
labkey-danield
self-requested a review
October 9, 2026 17:22
Contributor
|
Changes to shared test components does not automatically kick off tests for the apps. |
Contributor
Author
|
Verification runs on this branch for the two tests that failed on develop:
The failure rate was roughly 1 in 75 builds, so these runs show the fix doesn't break the tests but can't prove the race is gone. |
Contributor
Author
See separate followup comment - I just ran individual tests where I had seen failures instead of the full suite. I can run full suites if you think it's worth it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Fix intermittent Sample Manager test failures where the notifications dropdown re-renders while a test is reading it. Each notification refresh briefly replaces the listing with a loading spinner, so waits and clicks that hold an element reference fail with stale or missing elements. This hit 14 of 1,055 Sample Manager shard builds since 2026-09-01, across 10 branches including develop. Examples on develop: StaleElementReferenceException and NoSuchElementException.
Related Pull Requests
Changes