[bot] Merge 26.3 to 26.7 - #1011
Open
github-actions[bot] wants to merge 3 commits into
Open
Conversation
Updated 4 files to fix the errors being thrown by TeamCity build. My anesthesiaRecovery dataset will be created manually after deployment, so these files needed to be updated (per Marty) to ensure the automated tests know what the dataset will look like. - datasets_manifest.xml: Added my dataset to the list (fixes TeamCity error: WNPRC_EHRTest) - datasets_metadata.xml: Listed all the columns in my dataset (fixes TeamCity error: WNPRC_EHRTest) - wnprcEhrTestStudyPolicy.xml: Added my table permissions (fixes TeamCity error: testMprDataEntry) - wnprc_ios_appModule.java: Updated my schema after changing my upgrade script to 0.000-26.000 (fixes TeamCity error: SchemaXMLTestCase) ## Rationale <!-- Rationale describing why this pull request is needed, what behavior it's adding/changing/removing, etc. (replace this comment) --> ## Related Pull Requests - <!-- list of links to related pull requests (replace this comment) --> ## Changes - <!-- list of descriptions of changes that are worth noting (replace this comment) --> <!-- list of standard tasks (remove this comment to enable) ## Tasks 📍 - [ ] Claude Code Review - [ ] Manual Testing - [ ] Test Automation - [ ] Verify Fix -->
…1008) ## Rationale The "Import Results from File" list in the virology results grid could fail to render. Each candidate file's upload date comes from a webdav file-history lookup, and two paths through that lookup were broken: a file with no file system audit record threw on `history[0].data.date`, and the lookup's own failure callback called an undefined `reject`, throwing a ReferenceError instead of rejecting. Either one rejected the enclosing `Promise.all`, which had no rejection handler, so the window stayed behind a "Loading..." mask with no error shown. ## Changes - `getFileHistory` resolves instead of rejecting on a failed lookup, so one unreadable file no longer drops the whole import list. - Guarded the empty-history case; those files report their upload date as `Unknown` rather than a substituted timestamp. - Added a rejection handler to the `Promise.all` so failures hide the loading mask and surface an alert. - `getFileHistory` resolves `{name, uploaded}` rather than a positional `[filename, history]` pair.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated automatically.
Merging changes from: 2b7e2e8
Approve all matching PRs simultaneously.
Approval will trigger automatic merge.
Verify all PRs before approving: https://internal.labkey.com/Scrumtime/Backlog/harvest-gitOpenPullRequests.view?branch=26.7_fb_bot_merge_26.3