Streamline multisearch widget plugin - #212
Draft
matt-bernhardt wants to merge 10 commits into
Draft
Conversation
We retired the EBSCO Discovery Service some years ago, but never removed it as an option from the multisearch plugin until now. As we are simplifying this plugin significantly, the first step is to get rid of these templates.
This also removes the jQuery plugin that drives the tabbed search interface, because we are no longer supporting multiple search options in this widget. We also bump the plugin version to 1.8.0. Squash into alma removal
This reduces and combines the remaining conditional checks in the widget method, based on there now only being two template options. All conditionals are expressed in positive terms, as we no longer need to guard against "not this version" type checks.
It no longer makes sense to maintain two stylesheets for this widget, as we are attempting to simplify the styles with an eye toward removing as many of these styles as possible.
This is also a holdover from the EDS days, implemented prior to our pulling the search widget out to a separate plugin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Developer
Stylesheets
string incremented.
Secrets
Documentation
Accessibility
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Stakeholder approval
Dependencies
YES | NO dependencies are updated
Code Reviewer
(not just this pull request message)