[Fix|Local] Desktop release pnpm setup - #1774
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Desktop Releasedry run failed on all four targets in Setup pnpm:pnpm/action-setup@v5now errors when both the action'sversioninput and the rootpackage.jsonpackageManagerare setversion: 10input; the rootpackageManager: pnpm@10.26.0decides, as in every other workflow in the repoTest plan
workflow_dispatchonrelease-local.ymlfromdev,publish: never: Setup pnpm passes on all four runners and the build proceedsHigh-level PR Summary
This PR fixes a configuration conflict in the Desktop Release workflow where
pnpm/action-setup@v5was erroring due to having both the action'sversioninput and the rootpackage.jsonpackageManagerfield set. The fix removes the hardcodedversion: 10input from the workflow, allowing thepackageManagerfield inpackage.jsonto control the pnpm version, consistent with other workflows in the repository.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
.github/workflows/release-local.yml