Skip to content

[Fix|Local] Desktop release pnpm setup - #1774

Merged
CREDO23 merged 1 commit into
devfrom
fix/release-pnpm-setup
Sep 14, 2026
Merged

[Fix|Local] Desktop release pnpm setup#1774
CREDO23 merged 1 commit into
devfrom
fix/release-pnpm-setup

Conversation

@CREDO23

@CREDO23 CREDO23 commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • First Desktop Release dry run failed on all four targets in Setup pnpm: pnpm/action-setup@v5 now errors when both the action's version input and the root package.json packageManager are set
  • Drop the version: 10 input; the root packageManager: pnpm@10.26.0 decides, as in every other workflow in the repo

Test plan

  • workflow_dispatch on release-local.yml from dev, publish: never: Setup pnpm passes on all four runners and the build proceeds

High-level PR Summary

This PR fixes a configuration conflict in the Desktop Release workflow where pnpm/action-setup@v5 was erroring due to having both the action's version input and the root package.json packageManager field set. The fix removes the hardcoded version: 10 input from the workflow, allowing the packageManager field in package.json to control the pnpm version, consistent with other workflows in the repository.

⏱️ Estimated Review Time: 5-15 minutes

💡 Review Order Suggestion
Order File Path
1 .github/workflows/release-local.yml

Need help? Join our Discord

@vercel

vercel Bot commented Sep 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
surf-sense-frontend Ready Ready Preview Sep 14, 2026 1:10pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 64470de0-f424-4153-950d-ff33550ba573

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@CREDO23
CREDO23 merged commit ca8b599 into dev Sep 14, 2026
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant