Skip to content

chore: ImageMagick resource caps + server GC (MAPCO-11324) #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shimoncohen wants to merge 2 commits into
base: master
Choose a base branch
from
+14 −0
Open

chore: ImageMagick resource caps + server GC (MAPCO-11324) #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42bd8b1
chore: cap ImageMagick resources + server GC for the merge service (M…
shimoncohen Aug 4, 2026
f3e523e
refactor: isolate ImageMagick tuning, drop host-relative memory cap
shimoncohen Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions MergerLogic/Extensions/ServiceCollectionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ public static class ServiceCollectionExtensions
{
public static IServiceCollection RegisterMergerLogicType(this IServiceCollection collection, bool includeServiceProvider = true)
{
ConfigureImageMagick();

if (includeServiceProvider)
{
collection = collection.RegisterServiceProvider();
Expand All @@ -48,6 +50,15 @@ public static IServiceCollection RegisterImageProcessors(this IServiceCollection
.AddSingleton<ITileScaler, TileScaler>();
}

// Process-global ImageMagick tuning. Applied once at composition root, kept out of the DI
// registration methods so runtime side effects aren't hidden behind a "register services" call.
private static void ConfigureImageMagick()
{
// Tiles are already processed in parallel at the app level, so keep ImageMagick single-threaded
// per operation to avoid thread oversubscription.
ImageMagick.ResourceLimits.Thread = 1;
}

public static IServiceCollection RegisterMergerUtils(this IServiceCollection collection)
{
return collection
Expand Down
3 changes: 3 additions & 0 deletions MergerService/MergerService.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
<ImplicitUsings>enable</ImplicitUsings>
<DockerDefaultTargetOS>Linux</DockerDefaultTargetOS>
<RunWorkingDirectory>$(MSBuildProjectDirectory)</RunWorkingDirectory>
<!-- Throughput-oriented GC for the long-running, allocation-heavy merge service. -->
<ServerGarbageCollection>true</ServerGarbageCollection>
<ConcurrentGarbageCollection>true</ConcurrentGarbageCollection>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.VisualStudio.Azure.Containers.Tools.Targets" Version="1.14.0" />
Expand Down
Loading