Summary panel refactor#8019
Conversation
Coverage Report for CI Build 28303297397Coverage increased (+0.006%) to 90.251%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
david-yz-liu
left a comment
There was a problem hiding this comment.
@danielrafailov1 nice work, I just left a few minor comments
| if (remark_submitted) { | ||
| columns.push( | ||
| this.columnHelper.accessor("old_mark.mark", { | ||
| header: "Old Mark", |
There was a problem hiding this comment.
It was like this in the original version as well, but please internationalize this string ("Old Mark").
| meta: { | ||
| className: "number", | ||
| }, | ||
| cell: info => { |
There was a problem hiding this comment.
Use the parameter name props instead of info (this is more common throughout our codebase)
| this.columnHelper.accessor("description", { | ||
| header: I18n.t("activerecord.attributes.extra_mark.description"), | ||
| minSize: 150, | ||
| cell: info => { |
There was a problem hiding this comment.
Same comment here (and the other cell definitions below)
dc95794 to
7859b01
Compare
| not_in_same_assignment: result and criterion must all belong to the same assignment | ||
| models: | ||
| mark: | ||
| old: Old Mark |
There was a problem hiding this comment.
Ah, so locale files under models are really only for model names, attributes, and validation error messages. Please move this to views/results instead, as that's where most of the grading UI-related strings are stored
Proposed Changes
(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)
Refactored SummaryPanel component from react-table v6 to v8
Added tests
Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)