docs: turbopuffer sink - #38184
Closed
maheshwarip wants to merge 2 commits into
Closed
Conversation
Three lines in the turbopuffer sink guide ended with a single trailing space, which fails the `check-whitespace.sh` lint in the Lint and rustfmt CI step. A lone trailing space is not a Markdown hard line break, so removing it leaves the rendered page unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NPcYBkVtcvVrXt2KX4fYsM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuilds #38167 with its CI failure fixed. Carries the original
docs: turbopuffer sinkcommit unchanged, plus one commit that strips the trailing whitespace failing lint.The fix can also be cherry-picked onto the original branch instead of merging this PR:
git cherry-pick 88239bf.Motivation
The
buildkite/test/lint-and-rustfmtstep on #38167 fails. That step runsbin/lint, whosecheck-whitespace.shcheck rejects trailing whitespace viagit diff --check:Every other check on #38167 passes, including
lint-docs,preview-docs, andrun-docs-js-widgets-tests.Description
Three consecutive lines of the new turbopuffer sink guide ended with a single trailing space. Removing them is the whole fix. A lone trailing space is not a Markdown hard line break (that needs two or more), so the rendered page is byte-for-byte identical.
No content, wording, or structure was changed in the guide.
Verification
Reproduced the exact CI failure locally by running the script the failing step invokes, then confirmed it passes after the fix:
The remaining
bin/lintchecks that fail in this environment (check-cargo,check-formatting,check-generation,check-protobuf,check-trufflehog,check-zizmor,check-helm-docs,check-python-docs) fail for missing local tooling (buf,cargo-deny,cargo-deplint, an older local rustc) and are unrelated to this docs-only diff.check-copyright,check-python-files,check-slack-links, andcheck-test-flagspass.Generated by Claude Code