feat(search): wire up Cmd+K and polish the modal#11550
Merged
mergify[bot] merged 1 commit intoMay 19, 2026
Merged
Conversation
Follow-up to #11472, which visually refreshed the search modal but never actually bound Cmd+K. Adds the keybinding plus a round of UX polish on the modal itself. - Bind ⌘K / Ctrl+K to open the modal; header hint shows ⌘K on Mac and Ctrl K elsewhere (swapped client-side before paint). - Keep `/` working as the existing shortcut. - Open/close transitions: fade + blur the backdrop and gently scale the panel (180ms), with a delayed unmount so close also animates. Respects prefers-reduced-motion. - Backdrop now blurs the page (2px) behind a softer dim. - Input row: drop the blue focus outline; switch separator to --theme-divider to match the footer. - Empty state: centered icon, title, subtitle in the modal body. - Results list: rounded "card" rows, no per-section colored bar, no vertical divider before the preview pane. Rows keep their natural height so the list scrolls when there are many results. - Soft top/bottom gradient fades on the scrollable area; the top fade only shows once the list is actually scrolled. - Preview pane: aligned its top content with the first result row. - Dark mode: input-row separator now uses a token that's visible in dark mode. Change-Id: I21e6477732f048894836cfdb5a89262744a90e3f Claude-Session-Id: 5172c674-aa1d-419a-92e9-e6306c0563e0
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 👀 Review RequirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
JulianMaurin
approved these changes
May 18, 2026
jd
approved these changes
May 18, 2026
Contributor
Merge Queue Status
This pull request spent 11 hours 8 minutes 43 seconds in the queue, including 2 minutes 10 seconds running CI. Required conditions to merge
|
51 tasks
mergify
Bot
deleted the
devs/frank/devs/fl/search/cmd-k-keybinding/I21e6477732f048894836cfdb5a89262744a90e3f
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #11472, which visually refreshed the search modal but
never actually bound Cmd+K. Adds the keybinding plus a round of UX
polish on the modal itself.
and Ctrl K elsewhere (swapped client-side before paint).
/working as the existing shortcut.the panel (180ms), with a delayed unmount so close also animates.
Respects prefers-reduced-motion.
--theme-divider to match the footer.
vertical divider before the preview pane. Rows keep their natural
height so the list scrolls when there are many results.
fade only shows once the list is actually scrolled.
dark mode.