Skip to content

feat(kyc-controller): add session disclaimer fetching without sessionId - #10011

Open
jiexi wants to merge 2 commits into
mainfrom
jl/kyc-controller-consents-fetching-without-sessionId
Open

feat(kyc-controller): add session disclaimer fetching without sessionId#10011
jiexi wants to merge 2 commits into
mainfrom
jl/kyc-controller-consents-fetching-without-sessionId

Conversation

@jiexi

@jiexi jiexi commented Aug 28, 2026

Copy link
Copy Markdown
Member

Explanation

  • rename fetchDisclaimers to fetchVendorDisclaimers
    • Breaking, but kyc-controller is unreleased still
  • add support for fetchSessionDisclaimers without sessionId, using only country code

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Cursor Bugbot is generating a summary for commit d58a971. Configure here.

@jiexi
jiexi requested review from a team as code owners August 28, 2026 21:58
@jiexi
jiexi deployed to default-branch August 28, 2026 21:58 — with GitHub Actions Active
@jiexi jiexi changed the title feat(kyc-controller): a feat(kyc-controller): add session disclaimer fetching without sessionId Aug 28, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d58a971. Configure here.

SessionDisclaimersResponseStruct,
'session disclaimers',
GlobalDisclaimersResponseStruct,
'disclaimers',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One method serves two endpoints

Medium Severity

fetchSessionDisclaimers now performs both GET /sessions/{sessionId}/disclaimers and GET /disclaimers, with different response shapes. Data-service methods are meant to map to a single endpoint, and these overloads also collapse to the last signature in messenger call types, so the existing { sessionId } path no longer type-checks as a session catalog.

Fix in Cursor Fix in Web

Triggered by project rule: Guidance for Bugbot

Reviewed by Cursor Bugbot for commit d58a971. Configure here.

@cursor
cursor Bot requested review from Akaryatrh and georgeweiler August 28, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant