Skip to content

docs(assets-controllers): add spot-prices example URL for dev verification #9878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Prithpal-Sooriya merged 3 commits into from
Aug 14, 2026
+4 −4
Merged

docs(assets-controllers): add spot-prices example URL for dev verification #9878

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9889f78
docs(assets-controllers): add spot-prices example URL for dev verific…
cursoragent Aug 14, 2026
a85f532
docs(assets-controllers): add supportedNetworks link, shorten comment
cursoragent Aug 14, 2026
fb4d1bc
docs(assets-controllers): restructure spot-prices verification comments
cursoragent Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/assets-controllers/src/token-prices-service/codefi-v2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,11 +243,11 @@ const chainIdToNativeTokenAddress: Record<Hex, Hex> = {
export const getNativeTokenAddress = (chainId: Hex): Hex =>
chainIdToNativeTokenAddress[chainId] ?? ZERO_ADDRESS;

// Price API v3/spot-prices chains only — verify support before adding:

@salimtb salimtb Aug 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd love to have cursor adding PR comments around this

// Source: https://github.com/consensys-vertical-apps/va-mmcx-price-api/blob/main/src/constants/slip44.ts
// This list is ONLY for chains that are supported by the Price API v3/spot-prices endpoint.
// Please check that endpoint returns a price for the given assetId before including it in this list.
// Please include a comment with the name of the chain and the native symbol.
// Please keep the list sorted by chain ID.
// https://price.api.cx.metamask.io/v2/supportedNetworks
// https://price.api.cx.metamask.io/v3/spot-prices?assetIds=<CAIP-ASSET-ID>&vsCurrency=usd
// Include chain name + native symbol. Keep sorted by chain ID.
Comment thread
Prithpal-Sooriya marked this conversation as resolved.
export const SPOT_PRICES_SUPPORT_INFO = {
'0x1': 'eip155:1/slip44:60', // Ethereum Mainnet - Native symbol: ETH
'0xa': 'eip155:10/slip44:60', // OP Mainnet - Native symbol: ETH
Expand Down
Loading