fix: serialize URLs used in native download JavaScript - #79
Merged
Merged
Conversation
Unescaped urlString interpolation in download and iframe scripts allowed crafted URLs to break out of JS string literals and run in the current page origin. Serialize with RCTJSONStringify / JSONObject.quote instead. Co-authored-by: Cursor <cursoragent@cursor.com>
joaoloureirop
changed the title
tommasini
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RCTJSONStringifyon iOS,JSONObject.quoteon Android) before inserting them into native-generated JavaScript for file downloads and iframe URL reporting.Mobile can consume this via a published package bump.
Test plan