Skip to content

fix(gui): fix input validation and bounds clamping in WLongEdit - #6699

Merged
Big-Iron-Cheems merged 1 commit into
MeteorDevelopment:masterfrom
Big-Iron-Cheems:fix/wlongedit-correctness
Oct 9, 2026
Merged

Big-Iron-Cheems merged 1 commit into
MeteorDevelopment:masterfrom
Big-Iron-Cheems:fix/wlongedit-correctness

Conversation

@Big-Iron-Cheems

Copy link
Copy Markdown
Collaborator

Type of change

  • Bug fix
  • New feature

Description

The original implementation from #6691 dind't match the same checks we apply on other numeric inputs:

  • Restrict minus sign placement to cursor position 0
  • Validate parsed long during typing filter to prevent numeric overflow
  • Clamp out-of-bounds inputs using Math.clamp on unfocus
  • Add actionOnRelease callback support to match WIntEdit

Related issues

None.

How Has This Been Tested?

UI testing.

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

- Restrict minus sign placement to cursor position 0
- Validate parsed long during typing filter to prevent numeric overflow
- Clamp out-of-bounds inputs using Math.clamp on unfocus
- Add actionOnRelease callback support to match WIntEdit
@Big-Iron-Cheems
Big-Iron-Cheems merged commit 2385f7b into MeteorDevelopment:master Oct 9, 2026
1 check passed
@Big-Iron-Cheems
Big-Iron-Cheems deleted the fix/wlongedit-correctness branch October 9, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant