Repository navigation
Bump the pre-commit-hooks group with 5 updates - #971
Closed
dependabot[bot] wants to merge 2 commits into
Closed
dependabot[bot] wants to merge 2 commits into
dependabot[bot] wants to merge 2 commits into
Conversation
Bumps the pre-commit-hooks group with 5 updates: | Package | From | To | | --- | --- | --- | | [https://github.com/astral-sh/ruff-pre-commit](https://github.com/astral-sh/ruff-pre-commit) | `v0.15.15` | `0.16.4` | | [https://github.com/pre-commit/mirrors-mypy](https://github.com/pre-commit/mirrors-mypy) | `v1.15.0` | `2.3.1` | | [https://github.com/codingjoe/relint](https://github.com/codingjoe/relint) | `3.3.1` | `3.5.0` | | [https://github.com/codespell-project/codespell](https://github.com/codespell-project/codespell) | `v2.4.2` | `2.4.3` | | [https://github.com/rstcheck/rstcheck](https://github.com/rstcheck/rstcheck) | `v6.2.5` | `6.3.0` | Updates `https://github.com/astral-sh/ruff-pre-commit` from v0.15.15 to 0.16.4 - [Release notes](https://github.com/astral-sh/ruff-pre-commit/releases) - [Commits](astral-sh/ruff-pre-commit@v0.15.15...v0.16.4) Updates `https://github.com/pre-commit/mirrors-mypy` from v1.15.0 to 2.3.1 - [Commits](pre-commit/mirrors-mypy@v1.15.0...v2.3.1) Updates `https://github.com/codingjoe/relint` from 3.3.1 to 3.5.0 - [Release notes](https://github.com/codingjoe/relint/releases) - [Commits](codingjoe/relint@3.3.1...3.5.0) Updates `https://github.com/codespell-project/codespell` from v2.4.2 to 2.4.3 - [Release notes](https://github.com/codespell-project/codespell/releases) - [Commits](codespell-project/codespell@v2.4.2...v2.4.3) Updates `https://github.com/rstcheck/rstcheck` from v6.2.5 to 6.3.0 - [Changelog](https://github.com/rstcheck/rstcheck/blob/main/CHANGELOG.md) - [Commits](rstcheck/rstcheck@v6.2.5...v6.3.0) --- updated-dependencies: - dependency-name: https://github.com/astral-sh/ruff-pre-commit dependency-version: 0.16.4 dependency-type: direct:production dependency-group: pre-commit-hooks - dependency-name: https://github.com/pre-commit/mirrors-mypy dependency-version: 2.3.1 dependency-type: direct:production dependency-group: pre-commit-hooks - dependency-name: https://github.com/codingjoe/relint dependency-version: 3.5.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: pre-commit-hooks - dependency-name: https://github.com/codespell-project/codespell dependency-version: 2.4.3 dependency-type: direct:production dependency-group: pre-commit-hooks - dependency-name: https://github.com/rstcheck/rstcheck dependency-version: 6.3.0 dependency-type: direct:production dependency-group: pre-commit-hooks ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
for more information, see https://pre-commit.ci
Contributor
There was a problem hiding this comment.
Pull request overview
This PR primarily updates the repository’s pre-commit hook versions and includes a set of mechanical type-hint normalization changes (e.g., X | None ordering) across the Python codebase.
Changes:
- Bump multiple pre-commit hook revisions (ruff, mypy, relint, codespell, rstcheck).
- Normalize/standardize PEP 604 union type annotations across several modules.
- Minor typing cleanup in various method signatures/annotations.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.pre-commit-config.yaml |
Updates pre-commit hook revisions for ruff/mypy/relint/codespell/rstcheck. |
geoh5py/workspace/workspace.py |
Reorders union types in get_entity local variable annotation. |
geoh5py/ui_json/ui_json.py |
Reorders union types for __pydantic_extra__ annotation. |
geoh5py/shared/utils.py |
Normalizes union order in min_max_scaler parameter typing. |
geoh5py/objects/geo_image.py |
Normalizes union order in _create_geoimage_from_attributes signature. |
geoh5py/io/h5_writer.py |
Normalizes union order in fetch_handle return type. |
geoh5py/groups/interpretation_section.py |
Normalizes union order for local metadata typing. |
geoh5py/data/visual_parameters.py |
Normalizes union order in property return types and method return type. |
geoh5py/data/text_data.py |
Normalizes union order in text_formating signature. |
geoh5py/data/data_type.py |
Normalizes union order in local filter_min/filter_max annotations. |
Suppressed comments (2)
geoh5py/data/data_type.py:261
filter_min/valueare checked via truthiness (if filter_min and value ...), which skips validation when either is0(a valid float/int). This can allow an invalid range through and also interacts with the subsequentfloat(value) if value else Nonepattern that would drop0toNone. Prefer explicitis not Nonechecks for comparisons and assignments.
Note: the same pattern exists in filter_min’s setter (around lines 282–288) and should be updated consistently.
This issue also appears on line 282 of the same file.
filter_min: float | None = getattr(self, "_filter_min", None)
if filter_min and value and value < filter_min:
raise ValueError(
"Attribute 'filter_max' must be greater than or equal to 'filter_min'."
)
geoh5py/data/data_type.py:286
filter_max/valueare checked via truthiness (if filter_max and value ...), which skips validation when either is0(a valid float/int). This can allow an invalid range through and also interacts withfloat(value) if value else None(which would drop0toNone). Prefer explicitis not Nonechecks for comparisons and assignments.
Note: the same pattern exists in filter_max’s setter (around lines 257–263) and should be updated consistently.
filter_max: float | None = getattr(self, "_filter_max", None)
if filter_max and value and value > filter_max:
raise ValueError(
"Attribute 'filter_min' must be less than or equal to 'filter_max'."
)
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
|
|
||
| def text_formating(values: None | np.ndarray | str) -> ndarray | None: | ||
| def text_formating(values: np.ndarray | str | None) -> ndarray | None: |
Contributor
Author
|
Looks like these dependencies are updatable in another way, so this is no longer needed. |
dependabot
Bot
deleted the
dependabot/pre_commit/develop/pre-commit-hooks-bb45a0a7bb
branch
September 8, 2026 20:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the pre-commit-hooks group with 5 updates:
v0.15.150.16.4v1.15.02.3.13.3.13.5.0v2.4.22.4.3v6.2.56.3.0Updates
https://github.com/astral-sh/ruff-pre-commitfrom v0.15.15 to 0.16.4Release notes
Sourced from https://github.com/astral-sh/ruff-pre-commit's releases.
Commits
aab412dMirror: 0.16.465dbdb5Mirror: 0.16.37c55798Mirror: 0.16.26a246abBump astral-sh/setup-uv from 8.3.2 to 9.0.0 in the github-actions group (#179)39d9ac5Mirror: 0.16.1299cd31Bump actions/checkout from 7.0.0 to 7.0.1 in the github-actions group (#177)cb8c523Mirror: 0.16.0162e162Bump astral-sh/setup-uv from 8.2.0 to 8.3.2 in the github-actions group (#176)2700fd5Mirror: 0.15.2201a675eMirror: 0.15.21Updates
https://github.com/pre-commit/mirrors-mypyfrom v1.15.0 to 2.3.1Commits
7ff8d35Mirror: 2.3.141e6916Mirror: 2.3.00cbe8f6Mirror: 2.2.0d2823d3Mirror: 2.1.0a9d9ff5Mirror: 2.0.0fc0f09aMirror: 1.20.20f369d2Mirror: 1.20.18e5c807Mirror: 1.20.0a66e98dMirror: 1.19.1c273830Mirror: 1.19.0Updates
https://github.com/codingjoe/relintfrom 3.3.1 to 3.5.0Release notes
Sourced from https://github.com/codingjoe/relint's releases.
Commits
b1c90dfResolve #114 -- Always wrap code printed to the console (#146)757bca4[pre-commit.ci] pre-commit autoupdatec845e27[pre-commit.ci] pre-commit autoupdatea9c0e38Bump actions/checkout from 6 to 7fad6d65Limit allowed toolsd5a7f5fAdd Skills via Claude plugin3751a69[pre-commit.ci] pre-commit autoupdated36fea4Revert funding file49a477bFix #133 -- Handle git diff mnemonic prefixes (#137)8ace03a[pre-commit.ci] pre-commit autoupdateUpdates
https://github.com/codespell-project/codespellfrom v2.4.2 to 2.4.3Release notes
Sourced from https://github.com/codespell-project/codespell's releases.
... (truncated)
Commits
57b2140Read only [tool.codespell] from TOML config (#3975)23b8d94[pre-commit.ci] pre-commit autoupdate926c4d6[pre-commit.ci] pre-commit autoupdate820a301Merge pull request #3967 from codespell-project/peternewman-patch-19fe42c9Add common misspellings for reseeve->reserve to dictionary725173c[pre-commit.ci] pre-commit autoupdate86c13ee[pre-commit.ci] pre-commit autoupdate7b9f36cBump actions/checkout from 6 to 7bcc1b80Add spelling corrections for simpe and variants.89584cc[pre-commit.ci] pre-commit autoupdateUpdates
https://github.com/rstcheck/rstcheckfrom v6.2.5 to 6.3.0Changelog
Sourced from https://github.com/rstcheck/rstcheck's changelog.
Commits
d8774e9"release v6.3.0 [skip ci]"382bcc8Merge pull request #254 from rstcheck/support-rstcheck-core-1_3_193a53bdupdate changelogf69ee7cadd flag for new sphinx_source_dir setting88c8248bump min rstcheck-core version to 1.3.1b4f9612Merge pull request #253 from rstcheck/pre-commit-ci-update-config436c085ignore argument count of cli function2608287[pre-commit.ci] auto fixes from pre-commit.com hooks4be06fb[pre-commit.ci] pre-commit autoupdate96719d9Merge pull request #250 from rstcheck/pre-commit-ci-update-configDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions