DEVOPS-1131: Use ref_name and add release tag validation in python_deploy_prod.yml - #133
Open
RomFloreani wants to merge 1 commit into
Open
DEVOPS-1131: Use ref_name and add release tag validation in python_deploy_prod.yml#133RomFloreani wants to merge 1 commit into
RomFloreani wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the production Python deployment workflow to derive the release tag from the Git ref (instead of a manual workflow_dispatch input) and adds an early validation job to prevent non-tag manual runs from proceeding.
Changes:
- Removes the
release-tagmanual input and switches togithub.ref_nameas the fallback release tag source. - Adds a
validate-release-tagjob and wires it as a prerequisite for the publish jobs. - Updates workflow concurrency grouping to key off the release tag name / ref name.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+32
to
+39
| - name: Ensure this run was triggered from a tag | ||
| if: ${{ github.event_name == 'workflow_dispatch' && github.ref_type != 'tag' }} | ||
| env: | ||
| REF_TYPE: ${{ github.ref_type }} | ||
| REF_NAME: ${{ github.ref_name }} | ||
| run: | | ||
| echo "::error::This run was not triggered from a tag (ref_type=$REF_TYPE, ref_name=$REF_NAME). Re-run this workflow selecting the release tag under 'Use workflow from'." | ||
| exit 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEVOPS-1131 - python_deploy_prod workflow to use tag from revision: no manual input
Use github.ref_name instead of workflow_dispatch input release-tag, and add a validate-release-tag job to fail fast when the workflow is not run from a tag.
Mirrors the change made in MiraGeoscience/simpeg#167.