refactor(agent-core-v2): migrate agent domains to the agent runtime architecture - #3303
refactor(agent-core-v2): migrate agent domains to the agent runtime architecture#3303sailist wants to merge 14 commits into
Conversation
… drop the agent model system
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ea77749a6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| .get(IAgentLifecycleService) | ||
| .resolve(agentContextOf(agent), AgentFullCompaction); | ||
| return { | ||
| begin: ([input]: [{ source?: 'manual' | 'auto'; instruction?: string }]) => { |
There was a problem hiding this comment.
When session(...).agent(...).compact() uses the memory or IPC transport, the facade supplies the compaction object as the sole argument and the dispatcher spreads that argument list into this function. Destructuring the received object as [input] therefore throws TypeError: object is not iterable before runtime.begin() runs, breaking every compaction request over both transports; accept the payload object directly instead.
AGENTS.md reference: packages/klient/AGENTS.md:L21-L25
Useful? React with 👍 / 👎.
| const agent = resolved.like as IAgentScopeHandle; | ||
| const runtime = agent.accessor.get(IAgentLifecycleService).resolve(agentContextOf(agent), AgentLoop); | ||
| return { | ||
| cancelFromUser: () => runtime.cancelByUser(), |
There was a problem hiding this comment.
When a caller uses agent.cancel({ turnId }), the contract forwards that ID specifically to avoid cancelling an unrelated turn, but this adapter drops the argument and unconditionally cancels whichever turn is current. A delayed cancellation for an already-finished turn can consequently terminate a newer turn; forward the optional ID to a turn-aware cancellation path or reject it if that behavior is no longer supported.
AGENTS.md reference: packages/klient/AGENTS.md:L14-L20
Useful? React with 👍 / 👎.
| if (sessionId === null) return; | ||
| try { | ||
| await klient.session(sessionId).agent(agentId).service(IAgentLoopService).cancelFromUser(); | ||
| await (klient.session(sessionId).agent(agentId).service('agentLoopService') as { cancelFromUser(): Promise<void> }).cancelFromUser(); |
There was a problem hiding this comment.
When a turn is running and the inspector's Cancel action is clicked, this call always fails with 40001 unknown service: the migration removes the Agent-scoped agentLoopService, while kap-server's debug dispatcher only adds a compatibility view for agentPromptService (packages/kap-server/src/transport/dispatcher.ts:101-109). Add an AgentLoop debug adapter or invoke an existing cancellation route so the inspector can still stop turns.
AGENTS.md reference: apps/kimi-inspect/AGENTS.md:L22-L24
Useful? React with 👍 / 👎.
| const settlement = watchPromptSettlements(resolved.events); | ||
| settlement.settle(result.promptId, () => preparedMedia?.discard()); |
There was a problem hiding this comment.
When an external UserPromptSubmit hook blocks a prompt containing staged media, AgentPrompt.submit() emits prompt.completed before returning, but the settlement watcher is only created afterward. It therefore never observes that completion, enqueued remains true so the catch cleanup is bypassed, and the temporary IFileService objects owned by preparedMedia are never discarded; create and arm the watcher before awaiting submission, as the bundled-skill path already does.
Useful? React with 👍 / 👎.
1 participant
Related Issue
No linked issue — internal architecture migration (the agent-core-v2 Agent Runtime standard in
docs/features.md).Problem
Agent-granular domains in agent-core-v2 were Agent-scoped DI services (
IAgent*Service) with mutable registration surfaces and ad-hoc cross-domainruntime.get(...)edges. The Agent Runtime standard replaces this with per-domain opaque contract tokens, runtime-owned authoritative state, and resolve-only cross-domain access. This PR migrates the remaining agent domains to that architecture.What changed
onUndoand blob dehydrate/rehydrate channels; the shared agent event vocabulary moved to a common location.src/features/behind an opaque contract token. The legacyAgentSpace/defineAgentModelagent-model system was removed entirely.AgentToolsruntime. Plain and MCP tools enter as external provider/source contributions; the catalog, deferred disclosure/selection, and execution pipeline are internal to the runtime.manager.resolve(agentContext, Contract); transitional bridges live inside not-yet-migrated legacy services and are removed as those domains land.Checklist
test/features/<domain>/with case names preserved).gen-changesetsskill, or this PR needs no changeset — needs none: internal refactor, wire protocol and CLI behavior unchanged.gen-docsskill, or this PR needs no doc update — in-repo docs (target/domain docs, manifests) were updated alongside the code.