fix: generalize stable ABI extension porting for MUSA - #100
Merged
Conversation
xuezhaojiang
commented
Aug 13, 2026
xuezhaojiang
commented
Contributor
- rekey STABLE_TORCH_LIBRARY_IMPL CUDA registrations to PrivateUse1 for arbitrary namespaces and multiline macro invocations
- map stable ABI CUDA stream APIs to their MUSA equivalents
- map CUDA_VERSION to MUSA_VERSION
- define USE_MUSA for MUSA CUDAExtension builds
- cover in-place porting, non-CUDA dispatch keys, and generic namespaces
yeahdongcn
requested changes
Aug 14, 2026
| ) | ||
|
|
||
|
|
||
| def _rekey_stable_library_impl(source_code): |
Collaborator
There was a problem hiding this comment.
_rekey_stable_library_impl() 在过滤注释前对整个文件执行 regex，因此注释和字符串里的宏文本也会被改写。建议补 comment/string negative tests。
Contributor
Author
There was a problem hiding this comment.
检测是否是注释，和字符串，比较麻烦，而且感觉没必要。
xuezhaojiang
force-pushed
the
xzj/mapping
branch
2 times, most recently
from
August 14, 2026 09:16
639e92e to
c9abd08
Compare
- rekey STABLE_TORCH_LIBRARY_IMPL CUDA registrations to PrivateUse1
for arbitrary namespaces and multiline macro invocations
- map stable ABI CUDA stream APIs to their MUSA equivalents
- cover in-place porting, non-CUDA dispatch keys, and generic namespaces
- update version to 0.1.80.
xuezhaojiang
force-pushed
the
xzj/mapping
branch
from
August 14, 2026 10:45
c9abd08 to
830dbe4
Compare
yeahdongcn
approved these changes
Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.