Skip to content

docs(agent): warn on missing workflow labels - #2815

Merged
krishicks merged 1 commit into
mainfrom
chore/maintainer-authored-issue-acceptance/krishicks
Aug 24, 2026
Merged

docs(agent): warn on missing workflow labels#2815
krishicks merged 1 commit into
mainfrom
chore/maintainer-authored-issue-acceptance/krishicks

Conversation

@krishicks

@krishicks krishicks commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

Makes it so the agent does what I say when I want it to work on an issue that doesn't have the state:accepted label.

Related Issue

Changes

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

@copy-pr-bot

copy-pr-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@krishicks
krishicks force-pushed the chore/maintainer-authored-issue-acceptance/krishicks branch from 5cb5409 to bea6264 Compare August 19, 2026 20:49
@krishicks
krishicks enabled auto-merge August 19, 2026 20:49
elezar
elezar previously requested changes Aug 20, 2026

@elezar elezar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested

P1 — Include write-level maintainers: The repository’s issue-triage workflow treats write alongside maintain and admin as maintainer permission. Excluding it here means issues authored by write-level maintainers remain blocked despite this PR’s goal; use the same permission set or document why it differs.

While working on some triage tooling, I noted some inconsistency in the triage skill with respect to the new state labels and opened #2809 to address that. This PR and #2809 overlap in .agents/skills/triage-issue/SKILL.md, so they will need to be reconciled when this change is updated.

@krishicks
krishicks force-pushed the chore/maintainer-authored-issue-acceptance/krishicks branch from bea6264 to 90d218d Compare August 20, 2026 23:00
@krishicks
krishicks disabled auto-merge August 21, 2026 15:56
Signed-off-by: Kris Hicks <khicks@nvidia.com>
@krishicks krishicks changed the title docs(agent): accept maintainer-authored issues docs(agent): warn on missing workflow labels Aug 21, 2026
@krishicks
krishicks force-pushed the chore/maintainer-authored-issue-acceptance/krishicks branch from 90d218d to 9665b42 Compare August 21, 2026 16:00
@krishicks

krishicks commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator Author

I thought about this more and loosened this further so that the agent just does what a human wants, warning when the labels on the issue don't align with the request, because we don't want a robot to refuse a human's request to work on something, no matter if they're a maintainer or not.

@krishicks
krishicks enabled auto-merge August 21, 2026 16:04
@elezar

elezar commented Aug 24, 2026

Copy link
Copy Markdown
Member

I thought about this more and loosened this further so that the agent just does what a human wants, warning when the labels on the issu`e don't align with the request, because we don't want a robot to refuse a human's request to work on something, no matter if they're a maintainer or not.

Yes, having to toggle labels (or convince it that it's "just a POC") when starting on something was quite frustrating. Thanks for looking into this.

@elezar
elezar dismissed their stale review August 24, 2026 07:53

Changed

@krishicks
krishicks added this pull request to the merge queue Aug 24, 2026
Merged via the queue into main with commit 7fc6138 Aug 24, 2026
37 checks passed
@krishicks
krishicks deleted the chore/maintainer-authored-issue-acceptance/krishicks branch August 24, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants