Skip to content

ci(thirdparty-pulp): skip test_numpy_float in nightly cuOpt run#1190

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
rgsl888prabhu:ci/skip-pulp-numpy-float-test
May 8, 2026
Merged

ci(thirdparty-pulp): skip test_numpy_float in nightly cuOpt run#1190
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
rgsl888prabhu:ci/skip-pulp-numpy-float-test

Conversation

@rgsl888prabhu
Copy link
Copy Markdown
Collaborator

Summary

PuLP's test_numpy_float calls model.solve() without an explicit solver and relies on PuLP's default-solver auto-detection. CUOPT is not on that default list, so in our cuopt-only nightly test environment the call raises PulpError: No solver available and the test fails for reasons unrelated to cuOpt.

This PR deselects the test in ci/thirdparty-testing/run_pulp_tests.sh with an inline comment explaining the cause.

Context — other cuOpt-related PuLP failures

Test Status
test_unbounded Fixed upstream by coin-or/pulp#901 (tracked in #1114)
test_integer_infeasible_2 Fixed upstream by coin-or/pulp#901 (tracked in #1114)
test_infeasible_2 Real cuOpt bug — PDLP returns Optimal for an infeasible LP. Tracked in #1115. Not skipped here.
test_numpy_float This PR

Test plan

  • Nightly third-party-PuLP job no longer reports test_numpy_float as failing
  • Other cuOpt PuLP tests still execute (no over-broad deselect)

PuLP's test_numpy_float calls model.solve() without an explicit solver,
relying on the framework's default-solver auto-detection. CUOPT is not
on that default list, so in the cuopt-only test environment the call
raises "No solver available". Deselect the test with a comment
explaining the cause.

Other current cuOpt-related PuLP failures are tracked separately:
test_unbounded and test_integer_infeasible_2 are addressed by
coin-or/pulp#901 (under NVIDIA#1114), and test_infeasible_2 is tracked as NVIDIA#1115.
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 8, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@rgsl888prabhu rgsl888prabhu marked this pull request as ready for review May 8, 2026 18:58
@rgsl888prabhu rgsl888prabhu requested a review from a team as a code owner May 8, 2026 18:58
@rgsl888prabhu rgsl888prabhu requested a review from gforsyth May 8, 2026 18:58
@rgsl888prabhu rgsl888prabhu self-assigned this May 8, 2026
@rgsl888prabhu rgsl888prabhu added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels May 8, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 8, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 33239f6b-b648-470d-b19a-e6ba4243afda

📥 Commits

Reviewing files that changed from the base of the PR and between f3ab099 and 7ac7fe7.

📒 Files selected for processing (1)
  • ci/thirdparty-testing/run_pulp_tests.sh

📝 Walkthrough

Walkthrough

The PR modifies PuLP test execution in cuOpt-only environments by explicitly deselecting test_numpy_float from the pytest run via --deselect flag, with clarifying comments. The fallback mechanism—running run_tests.py when pytest exits with code 5—remains functionally identical.

Changes

Test Execution Configuration

Layer / File(s) Summary
Test Filtering Configuration
ci/thirdparty-testing/run_pulp_tests.sh
Pytest invocation adds --deselect pulp/tests/test_pulp.py::CUOPTTest::test_numpy_float with comments explaining that this test fails due to PuLP default-solver autodetection not including CUOPT in cuOpt-only environments.
Fallback Behavior
ci/thirdparty-testing/run_pulp_tests.sh
Conditional fallback to pulp/tests/run_tests.py when pytest finds no matching tests (exit code 5) is preserved unchanged; this run_tests.py path performs its own solver auto-detection.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: skipping test_numpy_float in the nightly cuOpt run for PuLP tests, which directly matches the changeset.
Description check ✅ Passed The description is directly related to the changeset, explaining the rationale for the test deselection, context about related PuLP failures, and the test plan.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@rgsl888prabhu
Copy link
Copy Markdown
Collaborator Author

/merge

@rapids-bot rapids-bot Bot merged commit b311a99 into NVIDIA:main May 8, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants