Track all row variables in Constraint.vars - #1737
Draft
jackthepunished wants to merge 1 commit into
Draft
Conversation
Quadratic rows stored only the variables of their linear terms, and updateConstraint did not record variables it introduced, so mapping a row's column indices back to Variables (compute_slack) could KeyError. Signed-off-by: jackthepunished <kosapinarbahadir@gmail.com>
jackthepunished
force-pushed
the
fix/constraint-vars
branch
from
August 18, 2026 06:50
f53442d to
84c88de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Constraint.varson a quadratic row held only the linear-term variables; variables that appear only in quadratic terms were missing.updateConstraintdid not add newly referenced variables toConstraint.vars, socompute_slackraisedKeyErrorfor them.Variables only, no coefficient copies.Checklist