Fix gpuop-cfg panic when validating a ClusterPolicy with no GDS configuration - #2792
Merged
Merged
Conversation
Signed-off-by: Karthikeyan Valliyurnatt <kvalliyurnat@nvidia.com>
kvalliyurnatt
requested review from
cdesiniotis,
karthikvetrivel,
rahulait,
rajathagasthya,
shivamerla and
tariq1890
as code owners
August 24, 2026 19:05
Signed-off-by: Karthikeyan Valliyurnatt <kvalliyurnat@nvidia.com>
kvalliyurnatt
force-pushed
the
fix_gpudirect_panic
branch
from
August 24, 2026 19:18
0c57784 to
2a2ae98
Compare
Signed-off-by: Karthikeyan Valliyurnatt <kvalliyurnat@nvidia.com>
rahulait
approved these changes
Aug 25, 2026
Contributor
|
Lets squash commits into 1 before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix gpuop-cfg panic when validating a ClusterPolicy with no GDS configuration. Skip validation for an omitted GDS spec and make ImagePath return an error instead of dereferencing a typed-nil pointer.
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing
Added unit tests also tested the CLI locally