Add CodeRabbit configuration to scope automated PR reviews - #2804
Open
karthikvetrivel wants to merge 1 commit into
Open
Add CodeRabbit configuration to scope automated PR reviews#2804karthikvetrivel wants to merge 1 commit into
karthikvetrivel wants to merge 1 commit into
Conversation
Signed-off-by: Karthik Vetrivel <kvetrivel@nvidia.com>
karthikvetrivel
requested review from
cdesiniotis,
rahulait,
rajathagasthya,
shivamerla and
tariq1890
as code owners
August 25, 2026 18:12
kvalliyurnatt
approved these changes
Aug 25, 2026
rajathagasthya
left a comment
Contributor
There was a problem hiding this comment.
Added some suggestions.
|
|
||
| # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json | ||
|
|
||
| tone_instructions: "Be direct, technical and brief. No praise or emoji. Skip style and formatting, which CI already gates. Without evidence in the diff, ask a question rather than assert a defect." |
Contributor
There was a problem hiding this comment.
Suggested change
| tone_instructions: "Be direct, technical and brief. No praise or emoji. Skip style and formatting, which CI already gates. Without evidence in the diff, ask a question rather than assert a defect." | |
| tone_instructions: "Be direct, technical and brief. No praise or emoji. Skip style and formatting, which CI already gates. Without evidence in the diff, ask a question rather than assert a defect. Name the concrete failure each finding prevents." |
Comment on lines
+120
to
+122
| Flag assertions that would still pass if the behaviour under test were | ||
| broken, and new operand or CRD behaviour that ships with no regression | ||
| test. Do not ask for tests covering generated or vendored code. |
Contributor
There was a problem hiding this comment.
Suggested change
| Flag assertions that would still pass if the behaviour under test were | |
| broken, and new operand or CRD behaviour that ships with no regression | |
| test. Do not ask for tests covering generated or vendored code. | |
| Flag assertions that would still pass if the behavior under test were | |
| broken, and new operand or CRD behaviour that ships with no regression | |
| test. Flag tests that mirror the implementation instead of checking | |
| behavior — the expected value is computed the same way as the code | |
| under test, or the test only checks that a mock was called. These break | |
| on refactors without catching bugs. | |
| Do not ask for tests covering generated or vendored code. |
Comment on lines
+90
to
+96
| ClusterPolicy, GPUCluster and NVIDIADriver are released CRDs that users | ||
| have already applied. Treat as major any removed or renamed field, | ||
| narrowed +kubebuilder:validation, changed +kubebuilder:default, or | ||
| changed Go type: each breaks existing custom resources on upgrade. | ||
| New fields must be optional and carry omitempty. | ||
| Editing these types requires regenerating the deepcopy and CRD assets, | ||
| so say so if the PR does not also update them. |
Contributor
There was a problem hiding this comment.
Suggested change
| ClusterPolicy, GPUCluster and NVIDIADriver are released CRDs that users | |
| have already applied. Treat as major any removed or renamed field, | |
| narrowed +kubebuilder:validation, changed +kubebuilder:default, or | |
| changed Go type: each breaks existing custom resources on upgrade. | |
| New fields must be optional and carry omitempty. | |
| Editing these types requires regenerating the deepcopy and CRD assets, | |
| so say so if the PR does not also update them. | |
| ClusterPolicy, GPUCluster and NVIDIADriver are released CRDs that users | |
| have already applied. Treat as major any removed or renamed field or | |
| json tag, a field made required, narrowed +kubebuilder:validation, | |
| changed +kubebuilder:default, or changed Go type: each breaks existing | |
| custom resources on upgrade. | |
| New fields must be optional and carry omitempty. | |
| Every new field is permanent API surface that must be supported across | |
| upgrades. Ask for justification when a new field duplicates an existing | |
| knob, could be derived from existing fields, or configures an | |
| implementation detail that could live in a ConfigMap or annotation | |
| instead. Spec holds user intent; status holds observed state; reject | |
| fields that blur that line. | |
| Editing these types requires regenerating the deepcopy and CRD assets, | |
| so say so if the PR does not also update them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I added a
.coderabbit.yamlso that CodeRabbit reviews this repo usefully.Two things about this repo would make a default install noisy.
The config addresses both:
quietprofile, so only critical and major findings are posted inline.dependabot[bot]andgithub-actions[bot]. A backport only replays commits that were already reviewed on main.vendor/, generated deepcopy and clientset code, the CRD copies thatmake sync-crdsproduces, and the intentionally malformed fixtures undertestdata/.golangci-lint, which CI already runs with our own config, andyamllint, which cannot parse our Helm and Go templates.Checklist
make lint)make validate-generated-assets)make validate-modules)Testing
This change adds no Go code, so there are no new code paths to cover and no Go artifacts to regenerate.