fix(stdexec): skip inline_scheduler's static_assert under nvcc - #2288
Open
alwaysprince05 wants to merge 1 commit into
Open
alwaysprince05 wants to merge 1 commit into
alwaysprince05 wants to merge 1 commit into
Conversation
Contributor
Author
|
/ok to test |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Including <stdexec/execution.hpp> fails to compile under nvcc (#2284):
The namespace-scope static_assert at the bottom of __inline_scheduler.hpp names the
private nested __sender type via schedule_result_t<inline_scheduler>, and nvcc's
parse-time evaluation doesn't see through the access the way host compilers do.
Fix
Guard the assert with
#if !defined(__CUDACC__), as suggested in #2284. The checkis a compile-time sanity check with no runtime effect; host compilers see no change.
I used the raw macro rather than STDEXEC_CUDA_COMPILATION() to keep the guard as
narrow as the reported failure — happy to switch if the wider macro is preferred.
fixes #2284
Verification
CUDACC is defined.
build and with STDEXEC_ENABLE_EXTRA_TYPE_CHECKING=ON.
toolchain (CI or a reviewer).