ForwardTranslate to new E+ SpaceLoad Instances + Definitions (opt-out possible) - #5651
Open
jmarrec wants to merge 11 commits into
Open
ForwardTranslate to new E+ SpaceLoad Instances + Definitions (opt-out possible)#5651jmarrec wants to merge 11 commits into
jmarrec wants to merge 11 commits into
Conversation
…SW) / excludeSpaceLoadInstances
…uipment or the new ElectricEquipment:Instance + Definition - ForwardTranslateElectricEquipmentDefinition.cpp (new): translates ElectricEquipmentDefinition → ElectricEquipment:Definition (raw, unmultiplied values). - ForwardTranslateElectricEquipment.cpp: translateElectricEquipment is now a 2-line dispatcher on m_forwardTranslatorOptions.excludeSpaceLoadInstances(); translateElectricEquipmentLegacy is the untouched original body (→ ElectricEquipment); translateElectricEquipmentInstance is new (→ ElectricEquipment:Instance, references the shared Definition via translateAndMapModelObject, which dedups automatically). - ForwardTranslator.hpp: forward-declared model::ElectricEquipmentDefinition, added the three new method declarations. - ForwardTranslator.cpp: OS_ElectricEquipment_Definition switch case now dispatches to translateElectricEquipmentDefinition instead of no-op (only exercised when the new path calls translateAndMapModelObject(definition), so legacy behavior is unaffected when the flag is off). - CMakeLists.txt: registered the new source file. - New tests Default behavior (excludeSpaceLoadInstances() == true) is unchanged — this is purely additive and opt-in.
…new SteamEquipment:Instance + Definition
…GasEquipment:Instance + Definition
… new Instance + Definition objects
…ElectricEquipment:ITE:AirCooled:Instance + Definition
…-load-instances` Existing tests that specifically target the legacy translation now opt-in explicitly via `ft.setExcludeSpaceLoadInstances(true)`
Contributor
🧪 Test Results DashboardSummary
❌ Significant Test Failures📊 Test Run Information
|
10 tasks
… (caught in OS-resources) The model (like the legacy ElectricEquipment:ITE:AirCooled object) stores 'Watts/Unit', but the new ElectricEquipment:ITE:AirCooled:Definition object renamed that choice to 'EquipmentLevel' to match the other *:Definition objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
ElectricEquipment:InstanceandElectricEquipment:DefinitionBehavior is that it will now by default translate to these new object pairs. But you can opt-out
A matching key in WorkflowJSON:
no_space_load_instancesA matching method
ForwardTranslator::setExcludeSpaceLoadInstances(bool)OpenStudio-resources
Add an ENV Variable to force space load instances translation or not OpenStudio-resources#234
I need to run the full regression tests suite at:
develop
this PR with USE_SPACE_LOAD_INSTANCES=false
this PR with USE_SPACE_LOAD_INSTANCES=true
and confirm there are no failing tests and no EUI deviations.
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.