You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All BLS operations take raw byte arrays (types.rs#L17-L21), so every call re-deserializes (verify does a G1 decompression per call) and re-runs subgroup checks — verify passes pk_validate = true and sig_groupcheck = true on every invocation. For a DV node the public shares are cluster-constant; nothing is memoized.
Additionally, aggregate_public_keys hand-rolls point addition through unsafe FFI and skips per-key subgroup validation — blst's safe AggregatePublicKey::aggregate(..., validate) covers it. A second independent blst wrapper with safe constructors already exists in pluto-frost (crates/frost/src/curve.rs); the ad-hoc scalar helpers in blst_impl.rs duplicate it.
There are no benchmarks: the only criterion setup in the workspace is crates/k1util/benches, while Charon benchmarks its BLS backend (tbls_test.goBenchmarkHerumiImplementation).
Proposed change
Introduce parsed key/signature types (wrapping blst types) validated once at construction; keep raw bytes only at serialization boundaries.
Add a batch-verification entry point and use it on the partial-signature paths.
Replace the unsafe aggregation with the blst safe API; consolidate scalar helpers with pluto-frost's wrappers.
Hoist the O(n²) scalar_from_u64 recomputation out of the interpolation loops — evaluate_polynomial rebuilds the same scalar every iteration and compute_lagrange_coefficients reconstructs per-index scalars inside the inner loop; build them once per index.
Add criterion benches (sign/verify/aggregate/threshold_aggregate) using the k1util bench as a template, so wins are measurable.
Activity