Fix NEST native Tsodyks synapse handling (issue #810)#830
Merged
apdavison merged 2 commits intoNeuralEnsemble:masterfrom May 4, 2026
Merged
Fix NEST native Tsodyks synapse handling (issue #810)#830apdavison merged 2 commits intoNeuralEnsemble:masterfrom
apdavison merged 2 commits intoNeuralEnsemble:masterfrom
Conversation
Member
apdavison
commented
May 4, 2026
apdavison
commented
- Replace string-based 'tsodyks' model name check with isinstance(TsodyksMarkramSynapse) in _connect() and _convergent_connect(), so tau_psc is only auto-copied from the post-synaptic neuron for the PyNN standard model, not for native_synapse_type.
- Fix broken tau_psc read in _connect(), which was reading from non-existent connections; now reads directly from the post-synaptic population's node_collection.
- Fix self.post -> projection.post in NESTConnectorMixin.synapse_parameters(), which caused AttributeError for inhibitory projections using the native connect path.
- Add three regression tests covering native tsodyks_synapse (both _convergent_connect and _connect paths) and native tsodyks2_synapse.
- Replace string-based 'tsodyks' model name check with isinstance(TsodyksMarkramSynapse) in _connect() and _convergent_connect(), so tau_psc is only auto-copied from the post-synaptic neuron for the PyNN standard model, not for native_synapse_type. - Fix broken tau_psc read in _connect(), which was reading from non-existent connections; now reads directly from the post-synaptic population's node_collection. - Fix self.post -> projection.post in NESTConnectorMixin.synapse_parameters(), which caused AttributeError for inhibitory projections using the native connect path. - Add three regression tests covering native tsodyks_synapse (both _convergent_connect and _connect paths) and native tsodyks2_synapse.
|
coverage: 70.796% (+0.2%) from 70.642% — apdavison:issue810 into NeuralEnsemble:master |
Member
Author
|
test failure is not related to the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.