Repository navigation
server: wait for the stores to disconnect on stop - #74
Merged
Merged
Conversation
hapi does not await server.events listeners, so server.stop() resolved while User and Session were still disconnecting. onPostStop runs inside stop(). routes/lifecycle.test.js fails on main and passes here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
msimerson
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
server.stop()resolved beforeUser.disconnect()andSession.disconnect()finished, because hapi doesn't awaitserver.eventslisteners.onPostStopruns insidestop(), so stop now waits for both.routes/lifecycle.test.jsholdsUser.disconnect()open and checks thatstop()is still pending. It fails on main and passes here.Tests: mysql 410/410, json 385/385, toml 385/385. Prettier is clean. eslint reports only the two existing warnings in
routes/index.js.