python3Packages.plotly: fix build with pytest 9 and numpy 2.4#493409
python3Packages.plotly: fix build with pytest 9 and numpy 2.4#493409GaetanLepage merged 2 commits intoNixOS:masterfrom
Conversation
`pytest_ignore_collect` takes only `collection_path` starting with pytest 9 [1]. Most of the paths referenced in `plotly/conftest.py` don't exist anymore and wouldn't be collected anyway, so we can just remove the file. Upstream PR: plotly/plotly.py#5521 [1] https://docs.pytest.org/en/latest/deprecations.html#py-path-local-arguments-for-hooks-replaced-with-pathlib-path
8cd0697 to
b2dd7c2
Compare
|
GaetanLepage
left a comment
There was a problem hiding this comment.
Thanks a lot for handling this, and especially for upstreaming the patches.
Actually, I would prefer if we would fetchpatch them directly, instead of vendoring them.
pkgs/development/python-modules/plotly/numpy-2.4-percentile-interpolation.patch
Outdated
Show resolved
Hide resolved
Sure! The relevant commits haven't been merged upstream yet, though. Shouldn't we vendor in this case? Referring to pkgs/README.md here. |
Yea, the way the patches are currently applied is the most correct way to do it given the upstream PRs are not merged. |
GaetanLepage
left a comment
There was a problem hiding this comment.
All good! Let's not block this one further.
Hydra: https://hydra.nixos.org/build/322261587/nixlog/4
pytest 9 and numpy 2.4 introduced a bunch of backward-incompatible changes that broke plotly in a few ways.
conftest.pyto fix compatibility with pytest 9 plotly/plotly.py#5521np.isininstead ofnp.in1dto fix numpy 2.4 test compatibility plotly/plotly.py#5522Fixes #493605
Things done
python3{13,14}Packages.plotlypassthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.