[FIX] queue_job: don't start the jobrunner in odoo shell

[GuillemCForgeFlow]

With queue_job in server_wide_modules, every odoo shell starts the job runner thread, stops it right away and waits for it, so the prompt only comes after 5 seconds:

INFO ? odoo.addons.queue_job.jobrunner: starting jobrunner thread (in threaded server)
INFO ? odoo.addons.queue_job.jobrunner.channels: Configured channel: root(C:2,Q:0,R:0,F:0)
INFO ? odoo.addons.queue_job.jobrunner.runner: graceful stop requested
INFO ? odoo.service.server: Initiating shutdown
INFO ? odoo.service.server: Hit CTRL-C again or send a second signal to force the shutdown.
INFO ? odoo.addons.queue_job.jobrunner.runner: starting      <- 5 s later
INFO ? odoo.addons.queue_job.jobrunner.runner: stopped

Cause. odoo/cli/shell.py starts the server with odoo.service.server.start(preload=[], stop=True), and ThreadedServer.run() passes the flag on to ThreadedServer.start(stop=stop). Core uses it to skip its own background services: the HTTP thread is only spawned if config['http_enable'] and not stop, and run() returns before cron_spawn(). The patched start of queue_job ignores it and only checks config["stop_after_init"], which the shell does not set. The runner thread sleeps START_DELAY (5 s) before running, and threaded_stop() joins it.

Fix. threaded_start() starts the runner only when the server is not started with stop=True, as core does for its HTTP and cron threads. A normal server start is unchanged, and --stop-after-init was already skipped in _start_runner_thread().

cc @ForgeFlow

[oca-cla-bot]

All commit authors signed the Contributor License Agreement.

[OCA-git-bot]

Hi @guewen,
some modules you are maintaining are being modified, check this out!

[AaronHForgeFlow]

👍

[GuillemCForgeFlow]

@guewen can we merge this one? 🙂

[guewen]

/ocabot merge patch

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-1003-by-guewen-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 983b6ad. Thanks a lot for contributing to OCA. ❤️

[GuillemCForgeFlow]

forward ports #1004 & #1005