Som Ramnani - feat(scroll-to-top-button): add scroll to top button component & remove querySelector workarounds - #5435
Open
somramnani wants to merge 3 commits into
Open
Conversation
…ve querySelector workarounds
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



NOT READY FOR REVIEW. PLEASE DO NOT REVIEW YET.
Description
This PR replaces the inconsistent legacy “Back to Top” implementations with a reusable global React component.
Previously:
document.querySelector.The new button appears on every route once the active page or nested container has scrolled more than 100px. Clicking it smoothly returns the active scroll container to the top.
Related PRS (if any):
This frontend PR is related to the issue in #5124
Main changes explained:
ScrollToTopButtoncomponent with:App.jsx.document.bodyto prevent it from being clipped by page overflow containers..topand.back-to-topHTML anchors and global styling.querySelectorlogic that previously hid or controlled the legacy button.How to test:
npm installand start the app locally./dashboard:/communityportal/communityportal/reports/resourceusage/TotalOrgSummaryEmailScreenshots or videos of changes:
PR.5435-Demo.mov
PR.5435-Demo-2.mov
Note: