chore: [SDK-5084] remove unsupported iOS compatibility code - #1726
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
nan-li
reviewed
Aug 26, 2026
Contributor
There was a problem hiding this comment.
most of my questions are around removing the outdated methods themselves. We've removed comments about being used on old iOS versions but we still kept them around and we lose that clarity, or we should get rid of the API if it is no longer applicable
Co-authored-by: Cursor <cursoragent@cursor.com>
nan-li
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Remove obsolete compatibility code for iOS versions below the SDK's iOS 12 minimum.
Details
Motivation
The SDK no longer supports iOS versions below 12, leaving runtime checks, fallbacks, selectors, constants, tests, and comments that cannot apply to supported devices.
Scope
Other
The removed Objective-C selectors were publicly visible but undocumented and unused internally. Distribution XCFramework headers are regenerated by the release process rather than edited manually.
Testing
Unit testing
Updated existing operation batching and subscription race tests to remove timing assumptions and prevent asynchronous work from leaking between tests.
Manual testing
UnitTestApptest bundle for an iOS simulator.UnitTestApp_TestPlan_Reducedsuccessfully on an iOS simulator.Affected code checklist
Checklist
Overview
Testing
Final pass
Made with Cursor