fix(typescript-fetch): support non-default file names#24006
Draft
celluj34 wants to merge 8 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
files generated with non-default (e.g. "fileNaming": "kebab-case") have their import path set with the default file name. this PR fixes the non-barrel imports by using the parsed file name instead of simply the class name.
(fixes #23840)
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Fixes broken model imports in the
typescript-fetchgenerator whenfileNamingis non-default (e.g., kebab-case). API files now import models using the actual generated file name instead of the class name.classFileName(viaconvertUsingFileNamingConvention) for model import paths inapis.mustacheandsagas.mustacheto support non-defaultfileNaming.TypeScriptFetchClientCodegenTestto assert kebab-case imports (e.g.,../models/petnot../models/Pet) and setWITHOUT_RUNTIME_CHECKSto false to exercise imports.bin/configs/typescript-fetch-kebab-case.yamland regenerated samples undersamples/client/petstore/typescript-fetch/builds/kebab-casefor coverage.Written for commit 80e5496. Summary will update on new commits.