fix(MergedSpecBuilder): merge path items by HTTP method instead of overwriting on path collision#24100
Draft
Picazsoo wants to merge 4 commits into
Draft
fix(MergedSpecBuilder): merge path items by HTTP method instead of overwriting on path collision#24100Picazsoo wants to merge 4 commits into
Picazsoo wants to merge 4 commits into
Conversation
…erwriting on path collision
…or reactive generators
… types for reactive generators" This reverts commit 8972528.
…lisions in open api merging test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Fixes OpenAPI merging to combine colliding paths by HTTP method and keep both operations. Builds a full merged spec with deduped components/servers and preserved vendor extensions.
Bug Fixes
x-vendor extensions on paths, operations, and schemas.http://localhost:8080if none exist.Refactors
OpenAPImodel via swaggerJson/Yamlmappers..yaml,.yml,.json; ignore invalid files; deterministic ordering; choose JSON output if the first spec is JSON.petstore-v3.1.yamloperationIds to avoid test collisions.Written for commit 818f196. Summary will update on new commits.