Skip to content

Add IATA code as Airport label on zoom 12-14#56

Open
CharliePlett wants to merge 4 commits intoOpenHistoricalMap:stagingfrom
CharliePlett:staging
Open

Add IATA code as Airport label on zoom 12-14#56
CharliePlett wants to merge 4 commits intoOpenHistoricalMap:stagingfrom
CharliePlett:staging

Conversation

@CharliePlett
Copy link
Copy Markdown
Contributor

This adds the iata= and icao= as the airport label beside the icon on zoom levels 12 to 14.

image

Added IATA code as Airport label beside the icon on zooms 12 to 14. If no IATA available then defaults to ICAO.
@CharliePlett
Copy link
Copy Markdown
Contributor Author

If this gets approved then the icao= and iata= would need to be added to the vtiles for this to take effect.

Copy link
Copy Markdown
Member

@erictheise erictheise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to drop the Airport icon entirely. Is that intentional?

I'm looking at SFO, https://localhost:8888/#13/37.62525/-122.38144, using our current version of staging and one to three airplanes appear from zoom ~10-14. I don't see any airplanes using your branch. I also don't see any IATA code; the only text that appears relates to taxiways and "San Francisco International Airport", and those begin to display at zoom 13.

Our staging branch:
image

Your staging branch:
image

@erictheise
Copy link
Copy Markdown
Member

Seems exposing the data is still pending in OpenHistoricalMap/issues#1314

@CharliePlett
Copy link
Copy Markdown
Contributor Author

I'm pretty sure the icon was showing when I created the pull request. Did something else change over time?

@erictheise
Copy link
Copy Markdown
Member

I cloned your repo and am running your staging branch directly. I'd suspect that dropping

"icon-size": ["interpolate", ["linear"], ["zoom"], 10, 1.2, 14, 1.5],

is the cause.

@CharliePlett
Copy link
Copy Markdown
Contributor Author

Can you fix it?

@CharliePlett
Copy link
Copy Markdown
Contributor Author

I messed up and accidentally moved my latest cemeteries commit into this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants