Skip to content

Property for splitting paths#5

Merged
martinsumner merged 4 commits into
OpenRiak:nhse-o40-orkv.i141-silvermachinefrom
ThomasArts:eqc-for-riak_api
Jun 9, 2026
Merged

Property for splitting paths#5
martinsumner merged 4 commits into
OpenRiak:nhse-o40-orkv.i141-silvermachinefrom
ThomasArts:eqc-for-riak_api

Conversation

@ThomasArts

@ThomasArts ThomasArts commented May 20, 2026

Copy link
Copy Markdown
Contributor

This QuickCheck property verifies that the URIs provided are split path correctly.

Given the quoting and %-encoding rules that apply this is not totally trivial and earlier versions did spot a few mistakes in the code.

We generate both valid and invalid URIs and verify that when an error is produced, the URI generated is indeed invalid. For valid URIs the path should split correctly.

All parameters should decode as tuples.

@ThomasArts ThomasArts marked this pull request as draft May 20, 2026 08:21
@ThomasArts ThomasArts marked this pull request as ready for review May 21, 2026 07:59
@martinsumner

Copy link
Copy Markdown
Contributor

The test needs to support OTP 26/28:

test/uri_eqc.erl:
    │
 56 │                      [{params, equals(Params, maps:get(query, URIMap, []))} || maps:get(query, URIMap, []) /= [{~"", true}] ]
    │                                                                                                                 ╰── syntax error before: '~'

     ┌─ test/uri_eqc.erl:
     │
 136 │  mk_path(_, []) -> ~"";
     │                    ╰── syntax error before: '~'

...

Is this an OTP 26 support issue?

@martinsumner martinsumner merged commit 8081d74 into OpenRiak:nhse-o40-orkv.i141-silvermachine Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants