Skip to content

CI hardening - #385

Open
0xNeshi wants to merge 6 commits into
mainfrom
ci/hardening
Open

0xNeshi wants to merge 6 commits into
mainfrom
ci/hardening

Conversation

@0xNeshi

@0xNeshi 0xNeshi commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@0xNeshi 0xNeshi self-assigned this Nov 2, 2026
@0xNeshi
0xNeshi requested a review from pepebndc as a code owner November 2, 2026 11:08
Copilot AI balanced review requested due to automatic review settings November 2, 2026 11:08
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The review reports no active issues with the workflow hardening and publishing authentication changes.

No open issues 🎉

What changed in this PR

This PR hardens GitHub Actions workflows for the Rust crate, updates crates.io publishing authentication, and adds compatibility and security checks.

Changes:

  • Disable persisted checkout credentials and explicitly limit benchmark workflow permissions.
  • Publish on release publication using short-lived crates.io tokens obtained through OpenID Connect.
  • Add semver and zizmor checks, while removing runner auditing from two existing check jobs.
File Description
.github/​workflows/​test.yml Disable persisted checkout credentials in tests.
.github/​workflows/​publish.yml Switch to release-triggered publishing with short-lived authentication.
.github/​workflows/​pr_benchmarks.yml Set read-only permissions and disable persisted checkout credentials.
.github/​workflows/​check.yml Add semver and security checks, harden checkouts, and adjust runner auditing.
.github/​workflows/​base_benchmarks.yml Set read-only permissions and disable persisted checkout credentials.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants