Repository navigation
CI hardening - #385
Open
0xNeshi wants to merge 6 commits into
Open
CI hardening#3850xNeshi wants to merge 6 commits into
0xNeshi wants to merge 6 commits into
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The review reports no active issues with the workflow hardening and publishing authentication changes.
No open issues 🎉
What changed in this PR
This PR hardens GitHub Actions workflows for the Rust crate, updates crates.io publishing authentication, and adds compatibility and security checks.
Changes:
- Disable persisted checkout credentials and explicitly limit benchmark workflow permissions.
- Publish on release publication using short-lived crates.io tokens obtained through OpenID Connect.
- Add semver and zizmor checks, while removing runner auditing from two existing check jobs.
| File | Description |
|---|---|
.github/workflows/test.yml |
Disable persisted checkout credentials in tests. |
.github/workflows/publish.yml |
Switch to release-triggered publishing with short-lived authentication. |
.github/workflows/pr_benchmarks.yml |
Set read-only permissions and disable persisted checkout credentials. |
.github/workflows/check.yml |
Add semver and security checks, harden checkouts, and adjust runner auditing. |
.github/workflows/base_benchmarks.yml |
Set read-only permissions and disable persisted checkout credentials. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.