Document undefined tracker behavior in track/untrack events. - #14189
Open
SuSeu1414 wants to merge 1 commit into
Open
Document undefined tracker behavior in track/untrack events.#14189SuSeu1414 wants to merge 1 commit into
SuSeu1414 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a player is teleported during this event, the entity tracker sometimes tracks the entities immediately and sometimes only in the next tick (depending on their order in player list). So if a plugin teleported me into a group of players inside this event, I would statistically see about half of them right away and the rest in the next tick.
This PR adds a javadoc note to PlayerTrackEntityEvent and PlayerUntrackEntityEvent warning that teleporting entities druing these events yields undefined tracker behavior