Add EntityLandEvent - #14204
Conversation
|
I would generally rather we modify the method signature (i.e. move the current onFall to a new method with the new param and leave the older signature to call the new method) with a callEvent boolean rather than hardcoding this sort of thing, more verbose but not fond of having a hardcoded list of avoidance states as that just tends to be missed |
should be better now |
| @@ -488,8 +_,18 @@ | ||
| } | ||
|
|
||
| public void fallOn(final Level level, final BlockState state, final BlockPos pos, final Entity entity, final double fallDistance) { |
There was a problem hiding this comment.
I believe this should be marked as final, that way all callers need to use the explict overriden method, the new method can probably be protected, see what others say here I guess
github-project-automation
Bot
moved this from Awaiting review
to Changes required
in Paper PR Queue
|
In actuality, this method looks like it's only called from a single place, is there any reason for this to need the modifications inside of events, etc? |
3 participants
This event is called when an entity lands on the block no matter the falling distance, useful for landing detection
