Fix Crash when hovering over the PvP toggle while having Shaper Beam - #10244
Merged
Conversation
Fixes the crash when you hover over the PvP toggle while having the Shaper Beam skill selected The skill uses the `DamageOverTime` config so `output.enemySkillTime` is never set so when the PvP calcs expect to find it they instead get a nil crash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Fixes the crash when you hover over the PvP toggle while having the Shaper Beam skill selected
The skill uses the
DamageOverTimeconfig sooutput.enemySkillTimeis never set so when the PvP calcs expect to find it they instead get a nil crashBefore screenshot:
After screenshot: