Conversation
- Import: https://pobarchives.com/build/{id} links, raw code at /build/{id}/raw - Export: POST the code to /api/pob/export, the response is the share link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This adds pobarchives.com to the build providers export/import list. I remember LocalIdentity suggesting me to add archives to the list few years back, which I was planning to, alas the unfortunate public builds integration incident went live first and this never had a chance to be there afterwards.
The reason I'm adding it now is that for the last few months I've redesigned the site and infrastructure completely, and I see exiles going out of their way to use "Add builds" button on the site, which means they like the layout, ease of use and all the features.
I know every provider on that list should be a site that is being maintained as well. My current maintenance pipeline has:
What site currently has for users, especially quality of life features for console players:
As you know, archives has been there for 3 years now, hand built before AI was there. I'm on a mission to preserve our build history, it has ~10 years of builds, and I take this project very seriously. The public outrage I received when we released the public/similar builds integration gave me boneshatter of complex trauma which eventually made me quit for a while, but it's all good now. I feel like I'm the Piety of tool devs nonetheless. Being a provider on that list feels natural to what the site is all about, and I would appreciate the honour if you welcome me again and the offer still exists. I think I can provide a solid alternative as a build site, and this will only motivate me to provide an even better service. I also want to contribute to PoB development as much as I can, be it new league to do list or bug fixes.
Site also supports PoB 2, which I will add a PR there as well.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobarchives.com/build/PkpDjB9H
Before screenshot:
After screenshot: